Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cart)!: change cart totals to dict #2608

Merged
merged 6 commits into from
Nov 22, 2023

Conversation

griest024
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Fixes: #2359

Does this PR introduce a breaking change?

[x] Yes
[ ] No

DaffCart#totals is now a dictionary

Other information

@griest024 griest024 added package: cart @daffodil/cart status: awaiting review This PR is awaiting review labels Nov 21, 2023
@griest024 griest024 self-assigned this Nov 21, 2023
@griest024 griest024 requested a review from a team as a code owner November 21, 2023 02:16
@griest024 griest024 requested review from a team as code owners November 21, 2023 03:31
@griest024 griest024 force-pushed the feat/cart/totals-dict branch from aa8101b to 8bdb152 Compare November 21, 2023 16:53
@griest024 griest024 merged commit a4f408f into graycoreio:develop Nov 22, 2023
17 checks passed
@griest024 griest024 deleted the feat/cart/totals-dict branch November 22, 2023 00:34
@gray-bot gray-bot mentioned this pull request Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: cart @daffodil/cart status: awaiting review This PR is awaiting review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] cart totals should be a dict
2 participants